lkml.org 
[lkml]   [2017]   [May]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH BUGFIX] block, bfq: access and cache blkg data only when safe
    From
    Date

    > Il giorno 19 mag 2017, alle ore 16:37, Jens Axboe <axboe@kernel.dk> ha scritto:
    >
    > On 05/19/2017 02:39 AM, Paolo Valente wrote:
    >> @@ -692,8 +725,7 @@ void bfq_pd_offline(struct blkg_policy_data *pd)
    >> /*
    >> * The idle tree may still contain bfq_queues belonging
    >> * to exited task because they never migrated to a different
    >> - * cgroup from the one being destroyed now. No one else
    >> - * can access them so it's safe to act without any lock.
    >> ++ * cgroup from the one being destroyed now.
    >> */
    >> bfq_flush_idle_tree(st);
    >>
    >
    > Looks like an extra '+' snuck into that hunk.
    >

    Yes, sorry. Before possibly submitting a fixed version, I'll wait for
    a reply on my previous email in this thread, as the issue now seems
    more serious to me, and affecting CFQ too.

    Thanks,
    Paolo

    > --
    > Jens Axboe
    >

    \
     
     \ /
      Last update: 2017-05-22 22:20    [W:3.513 / U:1.120 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site