lkml.org 
[lkml]   [2017]   [May]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/5] sctp: Delete an error message for a failed memory allocation in sctp_init()
On Mon, May 22, 2017 at 09:46:21PM +0200, SF Markus Elfring wrote:
> >> +++ b/net/sctp/protocol.c
> >> @@ -1447,5 +1447,4 @@ static __init int sctp_init(void)
> >> if (!sctp_ep_hashtable) {
> >> - pr_err("Failed endpoint_hash alloc\n");
> >
> > Okay but then why not also delete the one a few lines below this one:
> > if (!sctp_port_hashtable) {
> > pr_err("Failed bind hash alloc\n");
> > status = -ENOMEM;
> > goto err_bhash_alloc;
> > }
> > Seems the same pattern to me.
> >
> >> status = -ENOMEM;
> >> goto err_ehash_alloc;
> >> }
>
> How do you think about to remove the other error message in another
> update step if a consensus would be achieved in such a direction
> for this software module?

Fine by me.

Regards,
Marcelo

\
 
 \ /
  Last update: 2017-05-22 21:51    [W:0.043 / U:0.892 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site