lkml.org 
[lkml]   [2017]   [May]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] cpufreq: dt: Set default policy->transition_delay_ns
    On 22-05-17, 19:17, Leo Yan wrote:
    > This afternoon Amit pointed me for this patch, should fix as below?
    > Otherwise it seems directly assign the same value from unit 'ns' to
    > 'us' but without any value conversion.
    >
    > diff --git a/kernel/sched/cpufreq_schedutil.c b/kernel/sched/cpufreq_schedutil.c
    > index 76877a6..dcc90fc 100644
    > --- a/kernel/sched/cpufreq_schedutil.c
    > +++ b/kernel/sched/cpufreq_schedutil.c
    > @@ -538,7 +538,7 @@ static int sugov_init(struct cpufreq_policy *policy)
    > unsigned int lat;
    >
    > tunables->rate_limit_us = LATENCY_MULTIPLIER;
    > - lat = policy->cpuinfo.transition_latency / NSEC_PER_USEC;
    > + lat = policy->cpuinfo.transition_latency / NSEC_PER_MSEC;
    > if (lat)
    > tunables->rate_limit_us *= lat;
    > }

    I will let Rafael comment in as well. NSEC_PER_USEC is used in the
    earlier governors as well (ondemand/conservative) in exactly the same
    way as schedutil is using.

    --
    viresh

    \
     
     \ /
      Last update: 2017-05-22 13:29    [W:3.365 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site