Messages in this thread | | | Date | Tue, 23 May 2017 03:57:23 +0200 | From | Andrew Lunn <> | Subject | Re: [PATCH v3 5/5] mtd: mchp23k256: Add support for mchp23lcv1024 |
| |
> Agreed. How about this revised commit message > > --- 8< --- > mtd: mchp23k256: Add support for mchp23lcv1024 > > The mchp23lcv1024 is similar to the mchp23k256, the differences (from a > software point of view) are the capacity of the chip and the size of the > addresses used. > > There is no way to detect the specific chip so we must be told via a > Device Tree or default to mchp23k256 when device tree is not used. > > Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz> > Reviewed-by: Andrew Lunn <andrew@lunn.ch> > --- >8 ---
Yes, that is good.
> Can someone fixup the commit message or should I re-send?
The less the maintainer has to do, the more likely he will do it.
But hold on a few days, and see if you get any more comments.
Andrew
| |