Messages in this thread | | | Subject | Re: [PATCH 1/4] PCI: add resizeable BAR infrastructure v4 | From | Christian König <> | Date | Tue, 2 May 2017 16:56:55 +0200 |
| |
Am 26.04.2017 um 18:45 schrieb Andy Shevchenko: > [SNIP] >> -#define PCI_REBAR_CTRL_NBAR_MASK (7 << 5) /* mask for # bars */ >> -#define PCI_REBAR_CTRL_NBAR_SHIFT 5 /* shift for # bars */ >> +#define PCI_REBAR_CTRL_NBAR_MASK (7 << 5) /* mask for # BARs */ >> +#define PCI_REBAR_CTRL_NBAR_SHIFT 5 /* shift for # BARs */ > I understand why, but I dunno it worth to do. Bjorn suggested that. Either way is fine with me, but he needs to stick his signed-of-by on it when pushing it upstream. So his opinion usually wins.
All other comments will be integrated in the next version of the patch.
Thanks for the review, Christian.
| |