Messages in this thread | | | Date | Tue, 2 May 2017 17:40:21 +0800 | From | Ming Lei <> | Subject | Re: [PATCH 02/13] blk: replace bioset_create_nobvec() with a flags arg to bioset_create() |
| |
On Tue, May 02, 2017 at 01:42:24PM +1000, NeilBrown wrote: > "flags" arguments are often seen as good API design as they allow > easy extensibility. > bioset_create_nobvec() is implemented internally as a variation in > flags passed to __bioset_create().
From driver's view, this flag has document benifit too.
> > To support future extension, make the internal structure part of the > API. > i.e. add a 'flags' argument to bioset_create() and discard > bioset_create_nobvec(). > > Note that the bio_split allocations in drivers/md/raid* do not need > the bvec mempool - they should have used bioset_create_nobvec(). > > Suggested-by: Christoph Hellwig <hch@infradead.org> > Signed-off-by: NeilBrown <neilb@suse.com>
Reviewed-by: Ming Lei <ming.lei@redhat.com>
Thanks, Ming
| |