lkml.org 
[lkml]   [2017]   [May]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] perf/x86/intel: Drop kernel samples even though :u is specified
    From
    Date
    SNIP

    > I would much rather see this in generic code, somewhere around
    > __perf_event_overflow() I suppose. That would retain proper accounting
    > for the interrupt rate etc..
    >
    > Also it would work for all architectures. Because I'm thinking more than
    > just x86 will suffer from skid.
    Yes, moving to generic code is better. Thanks for the suggestion! I
    will do that.

    > If you're really worried, I suppose you can put it behind a PERF_PMU_CAP
    > flag or something.
    I guess what you are suggesting is to add checking like:

    if (is_sampling_event(event)) {
    if (event->pmu->capabilities & PERF_PMU_CAP_NO_INTERRUPT) {
    return;
    }
    }

    Is my understanding correct?

    Thanks
    Jin Yao


    \
     
     \ /
      Last update: 2017-05-19 14:07    [W:2.413 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site