Messages in this thread | | | From | Vivien Didelot <> | Subject | Re: [PATCH net-next 3/6] net: bridge: break if __br_mdb_del fails | Date | Thu, 18 May 2017 11:45:21 -0400 |
| |
Hi Nikolay,
Nikolay Aleksandrov <nikolay@cumulusnetworks.com> writes:
>> OK good to know. That intention wasn't obvious. I can make __br_mdb_del >> return void instead? What about the rest of the patchset if I do so? > > If you make it return void we will not be able to return proper error value > when doing a single operation (the else case). About the rest I see only some > minor style issues, I'll comment on the respective patches. Another minor nit is > using switch() instead of if/else for the message types but that is really up to > you, I don't mind either way. :-)
Ho OK I understand better the batch vs single delete operation now. __br_mdb_do hardly makes sense now, because we don't know which case we are handling... But factorizing br_mdb_do still makes sense. I'll come up with something.
Thanks,
Vivien
| |