Messages in this thread | | | Date | Thu, 18 May 2017 15:22:33 +0200 (CEST) | From | Miroslav Benes <> | Subject | Re: [PATCH 3/3] livepatch: force transition process to finish |
| |
On Thu, 18 May 2017, Libor Pechacek wrote:
> On Thu 18-05-17 14:00:43, Miroslav Benes wrote: > [...] > > Admin can do that now by writing 2 to force sysfs attribute in livepatch > > sysfs directory. TIF_PATCH_PENDING is then cleared for all tasks and the > > transition can finish successfully. > [...] > > --- a/include/linux/livepatch.h > > +++ b/include/linux/livepatch.h > > @@ -31,6 +31,7 @@ > > > > /* values for sysfs force attribute */ > > #define KLP_FORCE_FAKE 1 > > +#define KLP_FORCE_UNMARK 2 > > Again, needs documentation. I would consider using symbolic names instead of > numbers, like /sys/power/state does, even more friendly. Possibility to read a > list of available actions would help user space tools identify what is > available in case the list grows in the future.
I like that! -> v2
Thanks, Miroslav
| |