Messages in this thread | | | From | Gabriele Paoloni <> | Subject | RE: [PATCH v2 1/2] PCI/portdrv: add support for different MSI interrupts for PCIe port services | Date | Thu, 18 May 2017 10:08:15 +0000 |
| |
Hi Christoph
> -----Original Message----- > From: linux-pci-owner@vger.kernel.org [mailto:linux-pci- > owner@vger.kernel.org] On Behalf Of Christoph Hellwig > Sent: 18 May 2017 10:27 > To: Gabriele Paoloni > Cc: bhelgaas@google.com; helgaas@kernel.org; Linuxarm; linux- > pci@vger.kernel.org; lukas@wunner.de; linux-kernel@vger.kernel.org; > mika.westerberg@linux.intel.com; hch@infradead.org; liudongdong (C) > Subject: Re: [PATCH v2 1/2] PCI/portdrv: add support for different MSI > interrupts for PCIe port services > > > - * pcie_port_enable_msix - try to set up MSI-X as interrupt mode for > given port > > + * pcie_port_enable_msix_or_msi - try to set up MSI-X or MSI as > interrupt mode > > + * for given port > > just rename it to pcie_port_enable_vecs to avoid the overly long line..
The function is actually renamed but I missed to update the comment, my bad.
> > > + * pci_irq_vector() below is able to handle entry > differently > > + * depending on MSI vs MSI-x case > > As mentioned in the review for the other patch: no need to repeat > this for every user of pci_irq_vector.
I also missed to remove this comment
> > Otherwise this looks fine to me: > > Reviewed-by: Christoph Hellwig <hch@lst.de>
Many thanks I'll fix comments and send out v3 straight
Cheers Gab
| |