Messages in this thread | | | From | Arnd Bergmann <> | Date | Thu, 18 May 2017 11:09:16 +0200 | Subject | Re: [PATCH] scsi: smartpqi: mark PM functions as __maybe_unused |
| |
On Thu, May 18, 2017 at 10:32 AM, Arnd Bergmann <arnd@arndb.de> wrote: > The newly added suspend/resume support causes harmless warnings > when CONFIG_PM is disabled: > > smartpqi/smartpqi_init.c:5147:12: error: 'pqi_ctrl_wait_for_pending_io' defined but not used [-Werror=unused-function] > smartpqi/smartpqi_init.c:2019:13: error: 'pqi_wait_until_lun_reset_finished' defined but not used [-Werror=unused-function] > smartpqi/smartpqi_init.c:2013:13: error: 'pqi_wait_until_scan_finished' defined but not used [-Werror=unused-function] > > We can avoid the warnings by removing the #ifdef around the > handlers and instead marking them as __maybe_unused, which will > let gcc drop the unused code silently. > > Fixes: f44d210312a6 ("scsi: smartpqi: add suspend and resume support") > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
I notice that today's linux-next no longer contains the patch that introduced the warning.
Arnd
| |