Messages in this thread | | | Date | Fri, 19 May 2017 08:57:18 +0800 | From | Peter Chen <> | Subject | Re: [PATCH] usb: chipidea: debug: check before accessing ci_role |
| |
On Thu, May 18, 2017 at 04:14:14PM +0200, Michael Thalmeier wrote: > ci_role BUGs when the role is >= CI_ROLE_END. > > Signed-off-by: Michael Thalmeier <michael.thalmeier@hale.at> > --- > drivers/usb/chipidea/debug.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/chipidea/debug.c b/drivers/usb/chipidea/debug.c > index 6d23eed..1c31e8a 100644 > --- a/drivers/usb/chipidea/debug.c > +++ b/drivers/usb/chipidea/debug.c > @@ -294,7 +294,8 @@ static int ci_role_show(struct seq_file *s, void *data) > { > struct ci_hdrc *ci = s->private; > > - seq_printf(s, "%s\n", ci_role(ci)->name); > + if (ci->role != CI_ROLE_END) > + seq_printf(s, "%s\n", ci_role(ci)->name); > > return 0; > }
I will queue it, and cc stable
--
Best Regards, Peter Chen
| |