lkml.org 
[lkml]   [2017]   [May]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 0/4] KVM: x86: fix bugs reported by Dan Carpenter
2017-05-18 20:52+0200, Paolo Bonzini:
> On 18/05/2017 19:37, Radim Krčmář wrote:
> > It would be possible to make reproducers for the first three patches,
> > but they happen under circumstances too remote from normal use, so I
> > didn't test them like that. :)
> >
> >
> > Radim Krčmář (4):
> > KVM: nVMX: fix nested_vmx_check_vmptr failure paths under debugging
> > KVM: x86: zero base3 of unusable segments
> > KVM: x86/vPMU: fix undefined shift in intel_pmu_refresh()
> > KVM: x86: prevent uninitialized variable warning in check_svme()
> >
> > arch/x86/kvm/emulate.c | 2 +-
> > arch/x86/kvm/pmu_intel.c | 2 +-
> > arch/x86/kvm/vmx.c | 31 ++++++++++++++++++-------------
> > arch/x86/kvm/x86.c | 2 ++
> > 4 files changed, 22 insertions(+), 15 deletions(-)
> >
>
> Patch 1 is ugly, but I don't have any better idea.

I agree. Adding another argument was clearly worse, but I almost chose
to keep the skip in nested_vmx_check_vmptr() and return it +1, to signal
an error, and then subtract 1 before returning from the exit handler.

> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>

Thanks.

\
 
 \ /
  Last update: 2017-05-18 21:25    [W:0.115 / U:0.820 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site