Messages in this thread | | | From | David Carrillo-Cisneros <> | Date | Thu, 18 May 2017 11:30:35 -0700 | Subject | Re: [PATCH 7/7] perf tools: add feature header record to pipe-mode |
| |
On Thu, May 18, 2017 at 9:12 AM, Jiri Olsa <jolsa@redhat.com> wrote: > On Wed, May 17, 2017 at 09:16:02PM -0700, David Carrillo-Cisneros wrote: >> Add header record types to pipe-mode, reusing the functions >> used in file-mode and leveraging the new struct feat_fd. >> >> Add the perf_event__synthesize_feature event call back to >> process the new header records. >> >> Before this patch: >> >> $ perf record -o - -e cycles -c 100000 sleep 1 | perf report --stdio >> [ perf record: Woken up 1 times to write data ] >> [ perf record: Captured and wrote 0.000 MB - ] >> ... >> >> After this patch: >> $ perf record -o - -e cycles -c 100000 sleep 1 | perf report --stdio >> [ perf record: Woken up 1 times to write data ] >> [ perf record: Captured and wrote 0.000 MB - ] >> # hostname : lphh7 >> # os release : 4.11.0-dbx-up_perf >> # perf version : 4.11.rc6.g6277c80 >> # arch : x86_64 >> # nrcpus online : 72 >> # nrcpus avail : 72 >> # cpudesc : Intel(R) Xeon(R) CPU E5-2696 v3 @ 2.30GHz >> # cpuid : GenuineIntel,6,63,2 >> # total memory : 263457192 kB >> # cmdline : /root/perf record -o - -e cycles -c 100000 sleep 1 >> # HEADER_CPU_TOPOLOGY info available, use -I to display >> # HEADER_NUMA_TOPOLOGY info available, use -I to display >> # pmu mappings: intel_bts = 6, uncore_imc_4 = 22, uncore_sbox_1 = 47, uncore_cbox_5 = 33, uncore_ha_0 = 16, uncore_cbox >> Percent | Source code & Disassembly of kcore for cycles (9 samples) >> ... > > thanks a lot for doing this, comments comming shortly > thanks a lot for the review. I'll do the suggested changes and send a 2nd version.
David
| |