lkml.org 
[lkml]   [2017]   [May]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v5 1/2] selinux: add brief info to policydb
    2017-05-16 22:40 GMT+02:00 Stephen Smalley <sds@tycho.nsa.gov>:
    >> + strcpy(*brief, policydb.policybrief);
    >> + /* *len is the length of the output string */
    >> + *len = policybrief_len - 1;
    >
    > Is there a particular reason to not just return policybrief_len here as
    > well, for consistency in the interface? How do you intend to use this
    > value in the caller?

    As called in the other patch to expose policy brief via selinuxfs
    (sel_read_policybrief), the intent is to provide the caller with the
    length of the string returned.
    Or should I set *len to policy brief_len here, and just make the
    caller aware that the returned length is in fact the length of the
    buffer (i.e. including terminating NUL byte)?

    \
     
     \ /
      Last update: 2017-05-17 17:01    [W:3.141 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site