Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Wed, 17 May 2017 16:41:05 +0200 | Subject | Re: [PATCH] Partially Revert "of: fix sparse warnings in fdt, irq, reserved mem, and resolver code" |
| |
Hi Rob,
On Thu, May 11, 2017 at 5:30 PM, Rob Herring <robh@kernel.org> wrote: > A change to function pointers that was meant to address a sparse warning > turned out to cause hundreds of new gcc-7 warnings: > > include/linux/of_irq.h:11:13: error: type qualifiers ignored on function return type [-Werror=ignored-qualifiers] > drivers/of/of_reserved_mem.c: In function '__reserved_mem_init_node': > drivers/of/of_reserved_mem.c:200:7: error: type qualifiers ignored on function return type [-Werror=ignored-qualifiers] > int const (*initfn)(struct reserved_mem *rmem) = i->data;
Not just gcc-7. Also with the good old 4.1.2 ;-)
> Turns out the sparse warnings were spurious and have been fixed in > upstream sparse since 0.5.0 in commit "sparse: treat function pointers > as pointers to const data". > > This partially reverts commit 17a70355ea576843a7ac851f1db26872a50b2850. > > Fixes: 17a70355ea57 ("of: fix sparse warnings in fdt, irq, reserved mem, and resolver code") > Reported-by: Arnd Bergmann <arnd@arndb.de> > Signed-off-by: Rob Herring <robh@kernel.org>
Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |