lkml.org 
[lkml]   [2017]   [May]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] udp: make function udp_skb_dtor_locked static
From
Date
On Wed, 2017-05-17 at 09:50 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Function udp_skb_dtor_locked does not need to be in global scope
> so make it static to fix sparse warning:
>
> net/ipv4/udp.c: warning: symbol 'udp_skb_dtor_locked' was not
> declared. Should it be static?
>
> Fixes: 6dfb4367cd911d ("udp: keep the sk_receive_queue held when splicing")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> net/ipv4/udp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/ipv4/udp.c b/net/ipv4/udp.c
> index 7bd56c9889b3..922a62d45714 100644
> --- a/net/ipv4/udp.c
> +++ b/net/ipv4/udp.c
> @@ -1218,7 +1218,7 @@ void udp_skb_destructor(struct sock *sk, struct sk_buff *skb)
> EXPORT_SYMBOL(udp_skb_destructor);
>
> /* as above, but the caller held the rx queue lock, too */
> -void udp_skb_dtor_locked(struct sock *sk, struct sk_buff *skb)
> +static void udp_skb_dtor_locked(struct sock *sk, struct sk_buff *skb)
> {
> udp_rmem_release(sk, skb->dev_scratch, 1, true);
> }

Acked-by: Paolo Abeni <pabeni@redhat.com>

\
 
 \ /
  Last update: 2017-05-17 11:19    [W:0.032 / U:0.424 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site