Messages in this thread | | | Date | Wed, 17 May 2017 11:39:27 +0800 | From | Dong Aisheng <> | Subject | Re: [V2, 2/6] tty: serial: lpuart: add little endian 32 bit register support |
| |
On Tue, May 16, 2017 at 02:15:08PM +0300, Nikita Yushchenko wrote: > > static u32 lpuart32_read(void __iomem *addr) > > { > > - return ioread32be(addr); > > + return lpuart_is_be ? ioread32be(addr) : readl(addr); > > } > > > > static void lpuart32_write(u32 val, void __iomem *addr) > > { > > - iowrite32be(val, addr); > > + if (lpuart_is_be) > > + iowrite32be(val, addr); > > + else > > + writel(val, addr); > > } > > What if this is ever executed on big endian system? >
Sorry, not catching the point...
What issues will meet?
Regards Dong Aisheng
| |