lkml.org 
[lkml]   [2017]   [May]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [V2, 2/6] tty: serial: lpuart: add little endian 32 bit register support
On Tue, May 16, 2017 at 02:15:08PM +0300, Nikita Yushchenko wrote:
> > static u32 lpuart32_read(void __iomem *addr)
> > {
> > - return ioread32be(addr);
> > + return lpuart_is_be ? ioread32be(addr) : readl(addr);
> > }
> >
> > static void lpuart32_write(u32 val, void __iomem *addr)
> > {
> > - iowrite32be(val, addr);
> > + if (lpuart_is_be)
> > + iowrite32be(val, addr);
> > + else
> > + writel(val, addr);
> > }
>
> What if this is ever executed on big endian system?
>

Sorry, not catching the point...

What issues will meet?

Regards
Dong Aisheng

\
 
 \ /
  Last update: 2017-05-17 05:40    [W:0.252 / U:1.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site