lkml.org 
[lkml]   [2017]   [May]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] [iov_iter] use memmove() when copying to/from user page
On Tue, May 16, 2017 at 2:33 PM, Al Viro <viro@zeniv.linux.org.uk> wrote:
> On Tue, May 16, 2017 at 02:01:51PM -0700, Dmitry Vyukov wrote:
>
>> > In that case your patch does not suffice. Overlapping move _forwards_ still
>> > yields unexpected results, doesn't it?
>>
>> Why? memmove can move both ways. Do we need to change more memcpy's to
>> memmove's?
>
> Because it's not going to be *one* call of memcpy() or memmove(). It's
> one per page.


I missed that.

I assumed that in the case of sendfile from memfd to memfd data will
be copied directly. But it goes through a pipe with multiple buffers.
Does not look easily fixable.

\
 
 \ /
  Last update: 2017-05-17 00:16    [W:0.052 / U:2.172 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site