lkml.org 
[lkml]   [2017]   [May]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V1] i2c: xgene: Add support for I2C_FUNC_I2C functionality
On Wed, Apr 26, 2017 at 11:41:45AM +0700, tnhuynh@apm.com wrote:
> From: Tin Huynh <tnhuynh@apm.com>
>
> Certain I2C slave drivers, such as the pca95xx, require
> only I2C operations instead of SMBus extensions.
> This patch adds I2C_FUNC_I2C functionally to support those drivers.

No Signed-off, please run checkpatch on your patches!

> - return I2C_FUNC_SMBUS_BYTE |
> + return I2C_FUNC_I2C |
> + I2C_FUNC_SMBUS_BYTE |

Does this really work? You don't have a master_xfer function, so I think
it cannot work. You don't seem to have I2C_FUNC_I2C support in your driver.

> I2C_FUNC_SMBUS_BYTE_DATA |
> I2C_FUNC_SMBUS_WORD_DATA |
> I2C_FUNC_SMBUS_BLOCK_DATA |
> --
> 1.7.1
>
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2017-05-16 23:37    [W:0.035 / U:0.248 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site