Messages in this thread | | | Date | Tue, 16 May 2017 11:37:23 -0400 (EDT) | Subject | Re: [PATCH] rt2x00: improve calling conventions for register accessors | From | David Miller <> |
| |
From: Johannes Berg <johannes@sipsolutions.net> Date: Tue, 16 May 2017 13:58:56 +0200
> On Tue, 2017-05-16 at 13:55 +0200, Stanislaw Gruszka wrote: >> >> In rt2x00 driver we use poor convention in other kind of registers >> accessors like bbp, mac, eeprom. I dislike to changing only rfcsr >> accessors and leaving others in the old way. And changing all >> accessors would be massive and error prone change, which I'm not >> prefer either. > > That's a stupid argument, but for the sake of it - the conversion can > easily be done with coccinelle/spatch without being "error prone".
Agreed, we have tools for this.
| |