lkml.org 
[lkml]   [2017]   [May]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 04/11] arm64: dts: Initial DTS files for Broadcom Stingray SOC
    Hi,

    On Mon, May 15, 2017 at 05:32:14PM +0530, Anup Patel wrote:
    > +/ {
    > + chosen { /* Default kernel args */
    > + bootargs = "root=/dev/ram rw rootwait \
    > + earlycon=uart8250,mmio32,0x68a10000 \
    > + pci=pcie_bus_safe cma=64M";

    Why do we need all of these?

    > + linux,stdout-path = "serial0:115200n8";

    Please drop the 'linux,' prefix here.

    [...]

    > + memory: memory@80000000 {
    > + device_type = "memory";
    > + reg = <0x00000000 0x80000000 0 0x40000000>;
    > + };
    > +
    > + psci {
    > + compatible = "arm,psci-0.2";
    > + method = "smc";
    > + };
    > +
    > + pmu {
    > + compatible = "arm,armv8-pmuv3";
    > + interrupts = <GIC_PPI 7 IRQ_TYPE_LEVEL_HIGH>;
    > + };
    > +
    > + timer {
    > + compatible = "arm,armv8-timer";
    > + interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(8) |
    > + IRQ_TYPE_LEVEL_LOW)>,
    > + <GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(8) |
    > + IRQ_TYPE_LEVEL_LOW)>,
    > + <GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(8) |
    > + IRQ_TYPE_LEVEL_LOW)>,
    > + <GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(8) |
    > + IRQ_TYPE_LEVEL_LOW)>;

    GICv3 PPIs don't have a mask. See

    Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.txt

    Please remove the GIC_CPU_MASK_*() uses here and in this dts. They
    shouldn't be there.

    Thanks,
    Mark.

    \
     
     \ /
      Last update: 2017-05-15 15:14    [W:4.171 / U:0.396 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site