Messages in this thread | | | From | Gilad Ben-Yossef <> | Date | Sun, 14 May 2017 09:34:24 +0300 | Subject | Re: [PATCH] staging: ccree: remove unused function argument |
| |
Hi Arnd,
On Thu, May 11, 2017 at 2:38 PM, Arnd Bergmann <arnd@arndb.de> wrote: > "gcc -Wunused" warns about one argument being assigned but not used: > > drivers/staging/ccree/ssi_cipher.c: In function 'ssi_blkcipher_complete': > drivers/staging/ccree/ssi_cipher.c:747:41: error: parameter 'info' set but not used [-Werror=unused-but-set-parameter] > > We can simply drop that argument here and in its callers. > > Fixes: 302ef8ebb4b2 ("staging: ccree: add skcipher support") > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Thanks for spotting this. There used to be some code that used this parameter there, way back when.
The patch didn't apply after recent changes due to line moves so I re-based it and also took the opportunity to trim the > 80 char lines. I hope that is OK.
Thanks! Gilad
-- Gilad Ben-Yossef Chief Coffee Drinker
"If you take a class in large-scale robotics, can you end up in a situation where the homework eats your dog?" -- Jean-Baptiste Queru
| |