Messages in this thread | | | Date | Mon, 15 May 2017 09:44:30 +0900 | From | Namhyung Kim <> | Subject | Re: [PATCH v2] perf report: distinguish between inliners in the same function |
| |
Hi Andi,
On Fri, May 12, 2017 at 07:55:13AM -0700, Andi Kleen wrote: > Milian Wolff <milian.wolff@kdab.com> writes: > > > > I think I'm missing something, but isn't this what this function provides? The > > function above is now being used by the match_chain_inliner function below. > > > > Ah, or do you mean for code such as this: > > > > ~~~~~ > > inline_func_1(); inline_func_2(); > > This could be handled by looking at columns or discriminators too (which > some compilers generate in dwarf). srcline.c would need to be changed > to also call bfd_get_nearest_discriminator() and pass that extra > information everywhere.
You're right. The discriminators should be carried too.
Thanks, Namhyung
| |