Messages in this thread | | | From | Luc Van Oostenryck <> | Date | Thu, 11 May 2017 22:09:19 +0200 | Subject | Re: [PATCH] FS: Fixing return type of unsigned_offsets |
| |
On Thu, May 11, 2017 at 8:07 AM, Al Viro <viro@zeniv.linux.org.uk> wrote: > FVO"needed" equal to "needed to make sparse STFU"? If anything, that's > sparse being wrong - evaluate.c:check_assignment_type() should do > if (t == &ctype_bool) { > if (is_fouled_type(s)) > warning((*rp)->pos, "%s degrades to integer", > show_typename(s->ctype.base_type)); > goto Cast; > } > right after > } else if (!(sclass & TYPE_RESTRICT)) > goto Cast;
What about an explicit cast of restricted types to bool? I think we would want the equivalent of this patch for those too.
-- Luc
| |