Messages in this thread | | | Date | Thu, 11 May 2017 09:29:14 +0100 | From | Okash Khawaja <> | Subject | Re: [patch 1/1] staging: speakup: flush tty buffers and ensure hardware flow control |
| |
Hi Alan,
On Wed, May 10, 2017 at 08:41:51PM +0100, Alan Cox wrote: > > + if (!(tmp_termios.c_cflag & CRTSCTS)) { > > + tmp_termios.c_cflag |= CRTSCTS; > > + ret = tty_set_termios(tty, &tmp_termios); > > + if (ret) > > + pr_warn("speakup: Failed to set hardware flow control\n"); > > You should check the tty c_cflag after the call rather than rely on an > error code. Strictly speaking tty_set_termios should error if no tty bits > are changed by the request but it never has on Linux. Instead check the > tty gave you the result you wanted. Thanks. I will replace the check for return value with check for c_cflag.
May be we should fix this in tty_set_termios?
| |