lkml.org 
[lkml]   [2017]   [May]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.10 030/129] spi: armada-3700: Remove spi_master_put in a3700_spi_remove()
    Date
    4.10-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Wei Yongjun <weiyongjun1@huawei.com>

    commit e92f0051c0c65d7bee989884a233cfcd80303bdf upstream.

    The call to spi_master_put() in a3700_spi_remove() is redundant since
    the master is registered using devm_spi_register_master() and no
    reference hold by using spi_master_get() in a3700_spi_remove().

    This is detected by Coccinelle semantic patch.

    Fixes: 5762ab71eb24 ("spi: Add support for Armada 3700 SPI Controller")
    Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/spi/spi-armada-3700.c | 1 -
    1 file changed, 1 deletion(-)

    --- a/drivers/spi/spi-armada-3700.c
    +++ b/drivers/spi/spi-armada-3700.c
    @@ -901,7 +901,6 @@ static int a3700_spi_remove(struct platf
    struct a3700_spi *spi = spi_master_get_devdata(master);

    clk_unprepare(spi->clk);
    - spi_master_put(master);

    return 0;
    }

    \
     
     \ /
      Last update: 2017-05-11 17:54    [W:5.170 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site