lkml.org 
[lkml]   [2017]   [May]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.10 058/129] iwlwifi: mvm: fix accessing fw_id_to_mac_id
    Date
    4.10-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Sara Sharon <sara.sharon@intel.com>

    commit a95600294157ca7527ee7c70249fb53e09d8c566 upstream.

    Access should be by rcu_dereference. Issue was found by sparse.

    Fixes: 65e254821cee ("iwlwifi: mvm: use firmware station PM notification for AP_LINK_PS")
    Signed-off-by: Sara Sharon <sara.sharon@intel.com>
    Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c
    +++ b/drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c
    @@ -2411,7 +2411,7 @@ void iwl_mvm_sta_pm_notif(struct iwl_mvm
    return;

    rcu_read_lock();
    - sta = mvm->fw_id_to_mac_id[notif->sta_id];
    + sta = rcu_dereference(mvm->fw_id_to_mac_id[notif->sta_id]);
    if (WARN_ON(IS_ERR_OR_NULL(sta))) {
    rcu_read_unlock();
    return;

    \
     
     \ /
      Last update: 2017-05-11 16:18    [W:3.657 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site