Messages in this thread | | | From | David Howells <> | Subject | Re: [PATCH 3/9] VFS: Introduce a mount context | Date | Wed, 10 May 2017 09:05:18 +0100 |
| |
Miklos Szeredi <mszeredi@redhat.com> wrote:
> And the static string thing that David implemented is also a very good > idea, IMO.
There is an issue with it: it's fine as long as you keep a ref on the module that generated it or clear all strings as part of module removal (which the mount context in this patchset does). With the NFS mount context I did, I have to keep a ref on the NFS protocol module as well as the NFS filesystem module.
I'm tempted to make it conditionally copy the string using kvasprintf_const() - which would also permit format substitution.
David
| |