lkml.org 
[lkml]   [2017]   [May]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [v3 0/9] parallelized "struct page" zeroing
From
Date
> 
> Well, I didn't object to this particular part. I was mostly concerned
> about
> http://lkml.kernel.org/r/1494003796-748672-4-git-send-email-pasha.tatashin@oracle.com
> and the "zero" argument for other functions. I guess we can do without
> that. I _think_ that we should simply _always_ initialize the page at the
> __init_single_page time rather than during the allocation. That would
> require dropping __GFP_ZERO for non-memblock allocations. Or do you
> think we could regress for single threaded initialization?
>

Hi Michal,

Thats exactly right, I am worried that we will regress when there is no
parallelized initialization of "struct pages" if we force
unconditionally do memset() in __init_single_page(). The overhead of
calling memset() on a smaller chunks (64-bytes) may cause the
regression, this is why I opted only for parallelized case to zero this
metadata. This way, we are guaranteed to see great improvements from
this change without having regressions on platforms and builds that do
not support parallelized initialization of "struct pages".

However, on some chips such as latest SPARCs it is beneficial to have
memset() right inside __init_single_page() even for single threaded
case, because it can act as a prefetch on chips with optimized block
initialized store instructions.

Pasha

\
 
 \ /
  Last update: 2017-05-10 21:21    [W:0.074 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site