lkml.org 
[lkml]   [2017]   [May]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] net: dsa: loop: Free resources if initialization is deferred
Date
Free some devm'allocated memory in case of deferred driver initialization.
This avoid to waste some memory in such a case.

Suggested-by: Joe Perches <joe@perches.com>
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
drivers/net/dsa/dsa_loop.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/net/dsa/dsa_loop.c b/drivers/net/dsa/dsa_loop.c
index a19e1781e9bb..557afb418320 100644
--- a/drivers/net/dsa/dsa_loop.c
+++ b/drivers/net/dsa/dsa_loop.c
@@ -260,8 +260,11 @@ static int dsa_loop_drv_probe(struct mdio_device *mdiodev)
return -ENOMEM;

ps->netdev = dev_get_by_name(&init_net, pdata->netdev);
- if (!ps->netdev)
+ if (!ps->netdev) {
+ devm_kfree(&mdiodev->dev, ps);
+ devm_kfree(&mdiodev->dev, ds);
return -EPROBE_DEFER;
+ }

pdata->cd.netdev[DSA_LOOP_CPU_PORT] = &ps->netdev->dev;

--
2.11.0
\
 
 \ /
  Last update: 2017-05-10 21:20    [W:0.023 / U:3.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site