Messages in this thread | | | Subject | Re: [PATCH] dm ioctl: make dm_open and dm_release release | From | Colin Ian King <> | Date | Wed, 10 May 2017 10:19:29 +0100 |
| |
On 10/05/17 10:18, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > Making dm_open and dm_release static fixes the sparse warnings: > > warning: symbol 'dm_open' was not declared. Should it be static? > warning: symbol 'dm_release' was not declared. Should it be static? > > Fixes: ab2c6224f4c0c ("dm: a basic support for using the select or poll function") > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > drivers/md/dm-ioctl.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/md/dm-ioctl.c b/drivers/md/dm-ioctl.c > index 70dc5db90ef2..d45c68115d4c 100644 > --- a/drivers/md/dm-ioctl.c > +++ b/drivers/md/dm-ioctl.c > @@ -1893,7 +1893,7 @@ static long dm_compat_ctl_ioctl(struct file *file, uint command, ulong u) > #define dm_compat_ctl_ioctl NULL > #endif > > -int dm_open(struct inode *inode, struct file *filp) > +static int dm_open(struct inode *inode, struct file *filp) > { > int r; > struct dm_file *priv; > @@ -1911,7 +1911,7 @@ int dm_open(struct inode *inode, struct file *filp) > return 0; > } > > -int dm_release(struct inode *inode, struct file *filp) > +static int dm_release(struct inode *inode, struct file *filp) > { > kfree(filp->private_data); > return 0; >
Sorry, ignore this, it had a mistake in the subject line
| |