lkml.org 
[lkml]   [2017]   [May]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2 2/4] iio: accel: adxl345_core: Introduce set_mode and data_ready functions
On Mon, May 1, 2017 at 3:22 AM, Jonathan Cameron <jic23@kernel.org> wrote:
> On 29/04/17 08:48, Eva Rachel Retuya wrote:

>> +static int adxl345_set_mode(struct adxl345_data *data, u8 mode)
>> +{
>> + struct device *dev = regmap_get_device(data->regmap);
>> + int ret;
>> +
>> + ret = regmap_write(data->regmap, ADXL345_REG_POWER_CTL, mode);
>> + if (ret < 0) {
>> + dev_err(dev, "Failed to set power mode, %d\n", ret);
>> + return ret;
> drop the return ret here and just return ret at the end of the function.
> One of the static checkers will probably moan about this otherwise.

But this will be not equivalent!

>> + }
>> +
>> + return 0;
>> +}

--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2017-05-01 21:42    [W:0.103 / U:0.088 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site