lkml.org 
[lkml]   [2017]   [Apr]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] dmaengine: ioat: use setup_timer
On Sat, Apr 8, 2017 at 6:41 PM, Geliang Tang <geliangtang@gmail.com> wrote:
> Use setup_timer() instead of init_timer() to simplify the code.
>
> Signed-off-by: Geliang Tang <geliangtang@gmail.com>
> ---
> drivers/dma/ioat/init.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/dma/ioat/init.c b/drivers/dma/ioat/init.c
> index cc5259b..6ad4384 100644
> --- a/drivers/dma/ioat/init.c
> +++ b/drivers/dma/ioat/init.c
> @@ -760,9 +760,7 @@ ioat_init_channel(struct ioatdma_device *ioat_dma,
> dma_cookie_init(&ioat_chan->dma_chan);
> list_add_tail(&ioat_chan->dma_chan.device_node, &dma->channels);
> ioat_dma->idx[idx] = ioat_chan;
> - init_timer(&ioat_chan->timer);
> - ioat_chan->timer.function = ioat_timer_event;
> - ioat_chan->timer.data = data;
> + setup_timer(&ioat_chan->timer, ioat_timer_event, data);
> tasklet_init(&ioat_chan->cleanup_task, ioat_cleanup_event, data);
> }
>
> --
> 2.9.3
>

Reviewed-by: Dan Williams <dan.j.williams@intel.com>

\
 
 \ /
  Last update: 2017-04-09 20:04    [W:0.670 / U:0.300 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site