lkml.org 
[lkml]   [2017]   [Apr]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] char: misc: minor code cleanup
On Mon, Feb 27, 2017 at 11:27:58PM +0100, Martin Kaiser wrote:
> Fix a couple of minor issues found by checkpatch.pl:
>
> Add/remove spaces where required.
> Move EXPORT_SYMBOL() to the end of the function it refers to.
> Set the access mode for the proc entry explicity.
> Use pr_warn() instead of printk() without loglevel.

Always break up patches to only do 1 thing per patch.

thanks,

greg k-h

\
 
 \ /
  Last update: 2017-04-08 18:12    [W:0.074 / U:0.240 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site