Messages in this thread | | | Date | Sat, 8 Apr 2017 18:11:36 +0200 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH] char: misc: minor code cleanup |
| |
On Mon, Feb 27, 2017 at 11:27:58PM +0100, Martin Kaiser wrote: > Fix a couple of minor issues found by checkpatch.pl: > > Add/remove spaces where required. > Move EXPORT_SYMBOL() to the end of the function it refers to. > Set the access mode for the proc entry explicity. > Use pr_warn() instead of printk() without loglevel.
Always break up patches to only do 1 thing per patch.
thanks,
greg k-h
| |