Messages in this thread | | | Subject | Re: [PATCH] RDS: IB: ensure an initialized ret is printed in pr_warn message | From | Santosh Shilimkar <> | Date | Fri, 7 Apr 2017 08:59:46 -0700 |
| |
On 4/7/2017 7:24 AM, Dan Carpenter wrote: > Setting it to zero doesn't seem like the right thing, it should be an > error code. Oh, heh... Smatch parses this one correctly. "ret" is > always initialized but the code is probably buggy in a different way: >
[...]
> 561 ibmr = rds_ib_reg_fmr(rds_ibdev, sg, nents, key_ret); > 562 if (ibmr) > ^^^^ > This condition is always true because those functions return ERR_PTRs > not NULLs. > Thanks Dan. I will fix that up.
Regards, Santosh
| |