Messages in this thread | | | Subject | Re: [PATCH 4/9] bio-integrity: fix interface for bio_integrity_trim v2 | From | Hannes Reinecke <> | Date | Wed, 5 Apr 2017 08:36:01 +0200 |
| |
On 04/04/2017 08:56 PM, Dmitry Monakhov wrote: > bio_integrity_trim inherent it's interface from bio_trim and accept > offset and size, but this API is error prone because data offset > must always be insync with bio's data offset. That is why we have > integrity update hook in bio_advance() > > So only meaningful values are: offset == 0, sectors == bio_sectors(bio) > Let's just remove them completely. > > changes from v1: > - remove 'sectors' arguments > > Signed-off-by: Dmitry Monakhov <dmonakhov@openvz.org> > --- > block/bio-integrity.c | 11 ++--------- > block/bio.c | 4 ++-- > drivers/md/dm.c | 2 +- > include/linux/bio.h | 5 ++--- > 4 files changed, 7 insertions(+), 15 deletions(-) > Reviewed-by: Hannes Reinecke <hare@suse.com>
Cheers,
Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)
| |