lkml.org 
[lkml]   [2017]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: scope of cred_guard_mutex.
    On Wed, Apr 5, 2017 at 9:08 AM, Oleg Nesterov <oleg@redhat.com> wrote:
    > On 04/03, Eric W. Biederman wrote:
    >>
    >> You have asked why I have problems with your patch and so I am going to
    >> try to explain. Partly I want to see a clean set of patches that we
    >> can merge into Linus's tree before we make any compromises. Because the
    >> work preparing a clean patchset may inform us of something better. Plus
    >> we need to make something clean and long term maintainable in any event.
    >>
    >> Partly I object because your understanding and my understanding of
    >> cred_guard_mutex are very different.
    >
    > And I think there is another problem, your understanding and my understanding
    > of "clean" differ too much and it seems that we can not convince each other ;)
    >
    > The last series looks buggy (I'll send more emails later today), but the
    > main problem is that - in my opinion! - your approach is "obviously wrong
    > and much less clean". But yes, yes, I understand that this is my opinion,
    > and I can be wrong.
    >
    > Eric, I think we need more CC's. Linus, probably security list, the more
    > the better.
    >
    > I am going to resend my series with more CC's, then you can nack it and
    > explain what you think we should do. Perhaps someone else will suggest
    > a better solution, or at least review the patches. OK?

    I've been following along, but it seems like there are a lot of edge
    cases in these changes. I'll try to meaningfully comment on the coming
    emails... having code examples of why various things will/won't work
    go a long way for helping understand what's safe or not...

    -Kees

    --
    Kees Cook
    Pixel Security

    \
     
     \ /
      Last update: 2017-04-05 18:13    [W:4.118 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site