Messages in this thread | | | From | Andy Shevchenko <> | Date | Tue, 4 Apr 2017 19:56:51 +0300 | Subject | Re: [PATCH] watchdog: core: Make use of devm_register_reboot_notifier() |
| |
On Tue, Apr 4, 2017 at 7:51 PM, Guenter Roeck <linux@roeck-us.net> wrote: > On 04/04/2017 08:47 AM, Andy Shevchenko wrote: >> On Tue, Apr 4, 2017 at 5:10 PM, Andrey Smirnov <andrew.smirnov@gmail.com> >> wrote:
>>> + ret = devm_register_reboot_notifier(wdd->parent, >>> + &wdd->reboot_nb); >> >> >> I'm not sure it's logically correct. Perhaps binding to the actual >> watchdog device would be better. >> Though, Guenter can correct me. >> > > As mentioned in my other reply, it doesn't work since wdd->parent can be > NULL. > It might be possible to move the code into watchdog_dev_register() and tie > it > to the watchdog device, but I have not explored what that would require.
I would rather add device pointer to watchdoig struct, though it's your call :-) So, what you decide I'll agree with.
-- With Best Regards, Andy Shevchenko
| |