Messages in this thread | | | Date | Tue, 4 Apr 2017 11:02:39 -0500 | From | Reza Arbab <> | Subject | Re: [PATCH 0/6] mm: make movable onlining suck less |
| |
On Tue, Apr 04, 2017 at 10:23:02AM +0200, Michal Hocko wrote: >diff --git a/drivers/base/node.c b/drivers/base/node.c >index 5548f9686016..ee080a35e869 100644 >--- a/drivers/base/node.c >+++ b/drivers/base/node.c >@@ -368,8 +368,6 @@ int unregister_cpu_under_node(unsigned int cpu, unsigned int nid) > } > > #ifdef CONFIG_MEMORY_HOTPLUG_SPARSE >-#define page_initialized(page) (page->lru.next) >- > static int __ref get_nid_for_pfn(unsigned long pfn) > { > struct page *page; >@@ -380,9 +378,6 @@ static int __ref get_nid_for_pfn(unsigned long pfn) > if (system_state == SYSTEM_BOOTING) > return early_pfn_to_nid(pfn); > #endif >- page = pfn_to_page(pfn); >- if (!page_initialized(page)) >- return -1; > return pfn_to_nid(pfn); > } >
You can get rid of 'page' altogether.
drivers/base/node.c: In function ‘get_nid_for_pfn’: drivers/base/node.c:373:15: warning: unused variable ‘page’ [-Wunused-variable]
-- Reza Arbab
| |