Messages in this thread | | | From | Fabio Estevam <> | Date | Mon, 3 Apr 2017 09:00:20 -0300 | Subject | Re: [PATCH] pinctrl: core: Fix pinctrl_register_and_init() with pinctrl_enable() |
| |
Hi Tony,
On Thu, Mar 30, 2017 at 1:16 PM, Tony Lindgren <tony@atomide.com> wrote: > Recent pinctrl changes to allow dynamic allocation of pins exposed one > more issue with the pinctrl pins claimed early by the controller itself. > This caused a regression for IMX6 pinctrl hogs. > > Before enabling the pin controller driver we need to wait until it has > been properly initialized, then claim the hogs, and only then enable it. > > To fix the regression, split the code into pinctrl_claim_hogs() and > pinctrl_enable(). And then let's require that pinctrl_enable() is always > called by the pin controller driver when ready after calling > pinctrl_register_and_init(). > > Depends-on: 950b0d91dc10 ("pinctrl: core: Fix regression caused by delayed > work for hogs") > Fixes: df61b366af26 ("pinctrl: core: Use delayed work for hogs") > Fixes: e566fc11ea76 ("pinctrl: imx: use generic pinctrl helpers for > managing groups") > Cc: Fabio Estevam <festevam@gmail.com> > Cc: Gary Bisson <gary.bisson@boundarydevices.com> > Cc: Geert Uytterhoeven <geert@linux-m68k.org> > Cc: Haojian Zhuang <haojian.zhuang@linaro.org> > Cc: Masahiro Yamada <yamada.masahiro@socionext.com> > Cc: Mika Penttilä <mika.penttila@nextfour.com> > Cc: Mika Westerberg <mika.westerberg@linux.intel.com> > Cc: Nishanth Menon <nm@ti.com> > Cc: Shawn Guo <shawnguo@kernel.org> > Cc: Stefan Agner <stefan@agner.ch> > Signed-off-by: Tony Lindgren <tony@atomide.com>
Your patch fixes the pinctrl hog issue on a imx53-qsb board, thanks:
Tested-by: Fabio Estevam <fabio.estevam@nxp.com>
| |