Messages in this thread | | | From | "Kani, Toshimitsu" <> | Subject | Re: [PATCH 1/2] libnvdimm: fix clear length of nvdimm_forget_poison() | Date | Fri, 28 Apr 2017 22:41:53 +0000 |
| |
On Fri, 2017-04-28 at 15:39 -0700, Dan Williams wrote: > On Fri, Apr 28, 2017 at 3:29 PM, Kani, Toshimitsu <toshi.kani@hpe.com > > wrote: > > On Fri, 2017-04-28 at 14:48 -0700, Dan Williams wrote: > > > On Thu, Apr 27, 2017 at 3:57 PM, Toshi Kani <toshi.kani@hpe.com> : > > > > > > > > - nvdimm_forget_poison(nvdimm_bus, phys, len); > > > > + if (clear_err.cleared > 0) > > > > + nvdimm_forget_poison(nvdimm_bus, phys, > > > > clear_err.cleared); > > > > + > > > > return clear_err.cleared; > > > > > > Looks, good we need to mark this for -stable since the bug is > > > also present in current mainline. > > > > > > Fixes: e046114af5fc ("libnvdimm: clear the internal poison_list > > > when clearing badblocks") > > > > Shall I send a patch based on the current mainline with cc to > > -stable? The func name is nvdimm_clear_from_poison_list() in the > > mainline. > > I thinks it's too late to get a fix into 4.11, especially when this > went in broken and not a regression. I'll just tag this for -stable > and handle the backport manually.
Sounds great. Thanks Dan! -Toshi
| |