lkml.org 
[lkml]   [2017]   [Apr]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: ks7010: remove line continuations in quoted strings
On Fri, Apr 28, 2017 at 04:19:28PM +0200, Ilia Sergachev wrote:
> Checkpatch emits WARNING: Avoid line continuations in quoted strings.
>
> Remove line continuations - split strings using quotes.
>
> Signed-off-by: Ilia Sergachev <ilia.sergachev@unibas.ch>
> ---
> drivers/staging/ks7010/ks_hostif.c | 20 ++++++++++++++------
> 1 file changed, 14 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c
> index 7151f16e2f9c..a0c632a52f48 100644
> --- a/drivers/staging/ks7010/ks_hostif.c
> +++ b/drivers/staging/ks7010/ks_hostif.c
> @@ -191,9 +191,15 @@ int get_current_ap(struct ks_wlan_private *priv, struct link_ap_info_t *ap_info)
> wireless_send_event(netdev, SIOCGIWAP, &wrqu, NULL);
> }
> DPRINTK(4, "\n Link AP\n");
> - DPRINTK(4, " bssid=%02X:%02X:%02X:%02X:%02X:%02X\n \
> - essid=%s\n rate_set=%02X,%02X,%02X,%02X,%02X,%02X,%02X,%02X\n channel=%d\n \
> - rssi=%d\n sq=%d\n capability=%04X\n", ap->bssid[0], ap->bssid[1], ap->bssid[2], ap->bssid[3], ap->bssid[4], ap->bssid[5], &(ap->ssid.body[0]), ap->rate_set.body[0], ap->rate_set.body[1], ap->rate_set.body[2], ap->rate_set.body[3], ap->rate_set.body[4], ap->rate_set.body[5], ap->rate_set.body[6], ap->rate_set.body[7], ap->channel, ap->rssi, ap->sq, ap->capability);
> + DPRINTK(4, " bssid=%02X:%02X:%02X:%02X:%02X:%02X\n"
> + " essid=%s\n rate_set=%02X,%02X,%02X,%02X,%02X,%02X,%02X,%02X\n"
> + " channel=%d\n rssi=%d\n sq=%d\n capability=%04X\n",
> + ap->bssid[0], ap->bssid[1], ap->bssid[2],
> + ap->bssid[3], ap->bssid[4], ap->bssid[5],
> + &(ap->ssid.body[0]), ap->rate_set.body[0], ap->rate_set.body[1],
> + ap->rate_set.body[2], ap->rate_set.body[3], ap->rate_set.body[4],
> + ap->rate_set.body[5], ap->rate_set.body[6], ap->rate_set.body[7],
> + ap->channel, ap->rssi, ap->sq, ap->capability);

Could you indent it like this:

DPRINTK(4, " bssid=%02X:%02X:%02X:%02X:%02X:%02X\n"
" essid=%s\n rate_set=%02X,%02X,%02X,%02X,%02X,%02X,%02X,%02X\n"
" channel=%d\n rssi=%d\n sq=%d\n capability=%04X\n",
ap->bssid[0], ap->bssid[1], ap->bssid[2],
ap->bssid[3], ap->bssid[4], ap->bssid[5],
&(ap->ssid.body[0]), ap->rate_set.body[0], ap->rate_set.body[1],
ap->rate_set.body[2], ap->rate_set.body[3], ap->rate_set.body[4],
ap->rate_set.body[5], ap->rate_set.body[6], ap->rate_set.body[7],
ap->channel, ap->rssi, ap->sq, ap->capability);

And actually it might be more readable to break it up more:

DPRINTK(4, " bssid=%02X:%02X:%02X:%02X:%02X:%02X\n"
" essid=%s\n"
" rate_set=%02X,%02X,%02X,%02X,%02X,%02X,%02X,%02X\n"
" channel=%d\n"
" rssi=%d\n"
" sq=%d\n"
" capability=%04X\n",
ap->bssid[0], ap->bssid[1], ap->bssid[2],
ap->bssid[3], ap->bssid[4], ap->bssid[5],
&(ap->ssid.body[0]), ap->rate_set.body[0], ap->rate_set.body[1],
ap->rate_set.body[2], ap->rate_set.body[3], ap->rate_set.body[4],
ap->rate_set.body[5], ap->rate_set.body[6], ap->rate_set.body[7],
ap->channel, ap->rssi, ap->sq, ap->capability);

Except that's not really how newlines are supposed to work in dmesg...
Whatever.

regards,
dan carpenter

\
 
 \ /
  Last update: 2017-04-28 16:27    [W:0.282 / U:0.396 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site