lkml.org 
[lkml]   [2017]   [Apr]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH] staging: sm750fb: Combine set GPIO 30 & 31 into one statement
On Tue, Apr 25, 2017 at 03:53:02PM +0000, Lynn Lei wrote:
> Combine two separate set GPIO(30 & 31) operations into one statement.

Why?

>
> Signed-off-by: Lynn Lei <lynnl.jr@outlook.com>
> ---
> drivers/staging/sm750fb/ddk750_hwi2c.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/sm750fb/ddk750_hwi2c.c b/drivers/staging/sm750fb/ddk750_hwi2c.c
> index 68716ef7cb06..ddb7a6dc265a 100644
> --- a/drivers/staging/sm750fb/ddk750_hwi2c.c
> +++ b/drivers/staging/sm750fb/ddk750_hwi2c.c
> @@ -49,8 +49,7 @@ void sm750_hw_i2c_close(void)
>
> /* Set GPIO 30 & 31 back as GPIO pins */
> value = peek32(GPIO_MUX);
> - value &= ~GPIO_MUX_30;
> - value &= ~GPIO_MUX_31;
> + value &= ~(GPIO_MUX_30 | GPIO_MUX_31);

Why does this matter?

thanks,

greg k-h

\
 
 \ /
  Last update: 2017-04-28 14:02    [W:0.041 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site