Messages in this thread | | | Subject | Re: [PATCH 3/7] staging: rtl8723bs: Macros with complex values should be enclosed in parentheses | From | Larry Finger <> | Date | Thu, 27 Apr 2017 19:20:58 -0500 |
| |
On 04/27/2017 07:09 PM, Justin Vreeland wrote: > Signed-off-by: Justin Vreeland <justin@jvreeland.com> > --- > drivers/staging/rtl8723bs/hal/odm.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/rtl8723bs/hal/odm.h b/drivers/staging/rtl8723bs/hal/odm.h > index 0b3541a91548..13c4aebd178e 100644 > --- a/drivers/staging/rtl8723bs/hal/odm.h > +++ b/drivers/staging/rtl8723bs/hal/odm.h > @@ -209,7 +209,7 @@ typedef struct _ODM_RATE_ADAPTIVE { > > #define AVG_THERMAL_NUM 8 > #define IQK_Matrix_REG_NUM 8 > -#define IQK_Matrix_Settings_NUM 14+24+21 /* Channels_2_4G_NUM + Channels_5G_20M_NUM + Channels_5G */ > +#define IQK_Matrix_Settings_NUM (14+24+21) /* Channels_2_4G_NUM + Channels_5G_20M_NUM + Channels_5G */
You should also put spaces around the plus signs, and fix the lines with more then 80 columns.
The comment about non-blank commit messages also applies.
Larry
> > #define DM_Type_ByFW 0 > #define DM_Type_ByDriver 1 >
| |