Messages in this thread | | | Subject | Re: [PATCH net-next] can: fix build error without CONFIG_PROC_FS | From | Marc Kleine-Budde <> | Date | Thu, 27 Apr 2017 16:29:46 +0200 |
| |
Hello Arnd,
On 04/27/2017 04:21 PM, Arnd Bergmann wrote: > The procfs dir entry was added inside of an #ifdef, causing a build error > when we try to access it without CONFIG_PROC_FS set: > > net/can/bcm.c:1541:14: error: 'struct netns_can' has no member named 'bcmproc_dir' > net/can/bcm.c: In function 'bcm_connect': > net/can/bcm.c:1601:14: error: 'struct netns_can' has no member named 'bcmproc_dir' > net/can/bcm.c: In function 'canbcm_pernet_init': > net/can/bcm.c:1696:11: error: 'struct netns_can' has no member named 'bcmproc_dir' > net/can/bcm.c: In function 'canbcm_pernet_exit': > net/can/bcm.c:1707:15: error: 'struct netns_can' has no member named 'bcmproc_dir' > > This adds the same #ifdef around all users of the pointer. Alternatively > we could move the pointer outside of the #ifdef. > > Fixes: 384317ef4187 ("can: network namespace support for CAN_BCM protocol") > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
A fix for this problem is part of the pull request I send to David earlier today:
https://www.mail-archive.com/netdev@vger.kernel.org/msg165764.html
regards, Marc
-- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[unhandled content-type:application/pgp-signature] | |