Messages in this thread | | | From | Luca Coelho <> | Date | Thu, 27 Apr 2017 08:44:27 +0300 | Subject | Re: [PATCH v6 2/5] firmware: add extensible driver data API |
| |
On Thu, 2017-04-27 at 05:16 +0200, Luis R. Rodriguez wrote: > > > @@ -1460,6 +1471,128 @@ void release_firmware(const struct firmware *fw) > > > } > > > EXPORT_SYMBOL(release_firmware); > > > > > > +static int _driver_data_request_api(struct driver_data_params *params, > > > + struct device *device, > > > + const char *name) > > > +{ > > > + struct driver_data_priv_params *priv_params = ¶ms->priv_params; > > > + const struct driver_data_req_params *req_params = ¶ms->req_params; > > > + int ret; > > > + char *try_name; > > > + u8 api_max; > > > + > > > + if (priv_params->retry_api) { > > > + if (!priv_params->api) > > > + return -ENOENT; > > > + api_max = priv_params->api - 1; > > > + } else > > > + api_max = req_params->api_max; > > > > Braces. > > Not sure what you mean here, the else is a 1 liner so I skip the brace.
It's really a nitpick, but the CodingStyle[1] says:
"Do not unnecessarily use braces where a single statement will do. [...] This does not apply if only one branch of a conditional statement is a single statement; in the latter case use braces in both branches:
if (condition) { do_this(); do_that(); } else { otherwise(); }"
[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst#n175
-- Cheers, Luca.
| |