Messages in this thread | | | Date | Thu, 27 Apr 2017 13:53:58 +0200 | From | Pavel Machek <> | Subject | Re: [PATCH v3 09/29] x86: assembly, use DATA_SIMPLE for data |
| |
Hi!
> @@ -91,11 +91,11 @@ ENDPROC(do_suspend_lowlevel) > > .data > ALIGN > -ENTRY(saved_magic) .long 0 > -ENTRY(saved_eip) .long 0 > +SYM_DATA_SIMPLE(saved_magic, .long 0) > +SYM_DATA_SIMPLE_LOCAL(saved_eip, .long 0) > > # saved registers > -saved_idt: .long 0,0 > -saved_ldt: .long 0 > -saved_tss: .long 0 > +SYM_DATA_SIMPLE_LOCAL(saved_idt, .long 0,0) > +SYM_DATA_SIMPLE_LOCAL(saved_ldt, .long 0) > +SYM_DATA_SIMPLE_LOCAL(saved_tss, .long 0)
Do we really need to mark local data like that? It complicates the source code a bit... Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html [unhandled content-type:application/pgp-signature] | |