lkml.org 
[lkml]   [2017]   [Apr]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH v2 2/2] ARM: dts: Add the ethernet and ethernet PHY to the cygnus core DT.
    Date
    Florian Fainelli <f.fainelli@gmail.com> writes:

    > On 04/25/2017 04:53 PM, Eric Anholt wrote:
    >> Cygnus has a single AMAC controller connected to the B53 switch with 2
    >> PHYs. On the BCM911360_EP platform, those two PHYs are connected to
    >> the external ethernet jacks.
    >>
    >> Signed-off-by: Eric Anholt <eric@anholt.net>
    >> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
    >> ---
    >>
    >> v2: Call the node "switch", just call the ports "port" (suggestions by
    >> Florian), drop max-speed on the phys (suggestion by Andrew Lunn),
    >> call the other nodes "ethernet" and "ethernet-phy" (suggestions by
    >> Sergei Shtylyov)
    >>
    >> arch/arm/boot/dts/bcm-cygnus.dtsi | 58 ++++++++++++++++++++++++++++++++++
    >> arch/arm/boot/dts/bcm911360_entphn.dts | 8 +++++
    >> 2 files changed, 66 insertions(+)
    >>
    >> diff --git a/arch/arm/boot/dts/bcm-cygnus.dtsi b/arch/arm/boot/dts/bcm-cygnus.dtsi
    >> index 009f1346b817..9fd89be0f5e0 100644
    >> --- a/arch/arm/boot/dts/bcm-cygnus.dtsi
    >> +++ b/arch/arm/boot/dts/bcm-cygnus.dtsi
    >> @@ -142,6 +142,54 @@
    >> interrupts = <0>;
    >> };
    >>
    >> + mdio: mdio@18002000 {
    >> + compatible = "brcm,iproc-mdio";
    >> + reg = <0x18002000 0x8>;
    >> + #size-cells = <1>;
    >> + #address-cells = <0>;
    >
    > Sorry for not noticing earlier, since you override this correctly in the
    > board-level DTS file can you put a:
    >
    > status = "disabled"
    >
    > property in there by default?

    I didn't have the override in the board file either, just switch and
    ethernet. Fixed.
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2017-04-26 19:28    [W:3.094 / U:0.380 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site