lkml.org 
[lkml]   [2017]   [Apr]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH 1/3] ASoC: simple-card: Use devm_kcalloc() in asoc_simple_card_parse_aux_devs()
    From
    Date
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Wed, 26 Apr 2017 14:21:51 +0200

    A multiplication for the size determination of a memory allocation
    indicated that an array data structure should be processed.
    Thus use the corresponding function "devm_kcalloc".

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    sound/soc/generic/simple-card.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/sound/soc/generic/simple-card.c b/sound/soc/generic/simple-card.c
    index 2c9dedab5184..b59d51374b89 100644
    --- a/sound/soc/generic/simple-card.c
    +++ b/sound/soc/generic/simple-card.c
    @@ -334,8 +334,8 @@ static int asoc_simple_card_parse_aux_devs(struct device_node *node,
    if (n <= 0)
    return -EINVAL;

    - card->aux_dev = devm_kzalloc(dev,
    - n * sizeof(*card->aux_dev), GFP_KERNEL);
    + card->aux_dev = devm_kcalloc(dev, n, sizeof(*card->aux_dev),
    + GFP_KERNEL);
    if (!card->aux_dev)
    return -ENOMEM;

    --
    2.12.2
    \
     
     \ /
      Last update: 2017-04-26 15:07    [W:3.247 / U:0.608 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site